use localstorage to save account sidebar collapsed state #433

2024-02-11T14:39:17+08:00

ashleypean commented

2024-02-11 14:39:17 +08:00

(Migrated from github.com)

/claim #429

JoshAntBrown (Migrated from github.com) reviewed 2024-02-11 17:56:04 +08:00

app/views/accounts/_account_list.html.erb

						
				@@ -3,29 +3,29 @@

				<% accounts = Current.family.accounts.where(accountable_type: type.name) %>

JoshAntBrown (Migrated from github.com) commented

2024-02-11 17:56:04 +08:00

It might be better to make a more generic stimulus controller that persists the state of any details element rather than specifically just the account list.

Perhaps we could give the details element an id, and use that as it's key?

The name of the action could also be more descriptive, perhaps
toggle->details-state-controller#persistState?

It might be better to make a more generic stimulus controller that persists the state of any details element rather than specifically just the account list. Perhaps we could give the details element an id, and use that as it's key? The name of the action could also be more descriptive, perhaps `toggle->details-state-controller#persistState`?

ashleypean (Migrated from github.com) reviewed 2024-02-11 19:24:56 +08:00

app/views/accounts/_account_list.html.erb

						
				@@ -3,29 +3,29 @@

				<% accounts = Current.family.accounts.where(accountable_type: type.name) %>

ashleypean (Migrated from github.com) commented

2024-02-11 19:24:56 +08:00

Good point, udpated!

Shpigford commented

2024-02-12 02:40:25 +08:00

(Migrated from github.com)

Closing in favor of #432

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: gavin/maybe#433

				`@@ -3,29 +3,29 @@`
				`<% accounts = Current.family.accounts.where(accountable_type: type.name) %>`