gavin/maybe
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 28 Wiki Activity

Add Notifications UI #455

Closed
jclusso wants to merge 1 commits from notification_ui into main
pull from: notification_ui
merge into: gavin:main
Conversation 4 Commits 1 Files Changed 17 +66 -23
jclusso commented 2024-02-13 14:26:14 +08:00 (Migrated from github.com)
Copy Link

Resolves #447
/claim #447

Some key things to note:

  • Adds notifications UI
  • This implementation supports both flash on redirects (ex: redirect_to(root_path, alert: "Something went wrong") as well as flash on turbo stream responses (ex: turbo_stream.flash(alert: "Something went wrong"))
  • Replaces flash helper in auth views

https://github.com/maybe-finance/maybe/assets/622516/3b272e16-20f3-4a20-9684-96046814faf7

Resolves #447 /claim #447 Some key things to note: - Adds notifications UI - This implementation supports both flash on redirects (ex: `redirect_to(root_path, alert: "Something went wrong")` as well as flash on turbo stream responses (ex: `turbo_stream.flash(alert: "Something went wrong")`) - Replaces flash helper in auth views https://github.com/maybe-finance/maybe/assets/622516/3b272e16-20f3-4a20-9684-96046814faf7
🚀 1
algora-pbc[bot] commented 2024-02-13 14:26:20 +08:00 (Migrated from github.com)
Copy Link

💵 To receive payouts, sign up on Algora, link your Github account and connect with Stripe/Alipay.

💵 To receive payouts, [sign up on Algora](https://console.algora.io/auth/signup), [link your Github account](https://console.algora.io/onboarding/solver) and [connect with Stripe/Alipay](https://console.algora.io/onboarding/solver).
jclusso (Migrated from github.com) reviewed 2024-02-13 15:08:05 +08:00
config/tailwind.config.js
@@ -207,0 +208,4 @@
'stroke-fill': {
to: { 'stroke-dashoffset': 0 },
},
},
jclusso (Migrated from github.com) commented 2024-02-13 15:08:05 +08:00
Copy Link

Credit to @JoshAntBrown since I stole this from #449. I'm not crazy about having to add something to the tailwind config, so if there is a better way to do this, let me know.

Credit to @JoshAntBrown since I stole this from #449. I'm not crazy about having to add something to the tailwind config, so if there is a better way to do this, let me know.
mogery commented 2024-02-13 17:32:40 +08:00 (Migrated from github.com)
Copy Link

Awesome, thorough code! 👏🏻

Awesome, thorough code! 👏🏻
😆 1
henrikbjorn (Migrated from github.com) reviewed 2024-02-13 19:42:34 +08:00
app/helpers/turbo_streams/flash_message_helper.rb
@@ -0,0 +2,4 @@
def flash_message(flash)
messages = flash.map do |type, message|
turbo_stream_action_tag(:flash_message, type: type, message: message)
end.join.html_safe
henrikbjorn (Migrated from github.com) commented 2024-02-13 19:42:34 +08:00
Copy Link

You can also use .safe_join https://api.rubyonrails.org/classes/ActionView/Helpers/OutputSafetyHelper.html#method-i-safe_join

You can also use `.safe_join` https://api.rubyonrails.org/classes/ActionView/Helpers/OutputSafetyHelper.html#method-i-safe_join

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
jclusso
henrikbjorn
Labels
Clear labels
📆 Planned
Not ready to be worked on yet, but planned for future
 💻 Self Hosted only
Issues pertaining to self-hosted versions of Maybe
 ⚙️ Config
ℹ️ Needs info
Further information is requested
 📱 Mobile
Bugs exclusively happening on mobile devices
 1️⃣ High Priority
High priority issues will be worked on next
 🚨 Urgent
Issues that are urgent for app functionality
 3️⃣ Low priority
Contributions accepted, but Maybe team will not be working on this in the near term
 2️⃣ Medium Priority
Community contributions accepted, Maybe team only works on if there are no high priority items open
 ⚡ Performance
Performance issues to address
 🎨 UI / UX
Issues related to UI / UX interactions and design.
 💎 Bounty
💰 Rewarded
📊 Data issue
Issues where the app functionally works, but the data is missing or inaccurate.
 🙋 Bounty claim
$1.5K
Community
This is a great issue for community members to work on
 dependencies
Pull requests that update a dependency file
 Design
Hosted only
Hosted app only
 Required self hoster data migration
Self hosters must run data migrations to resolve this issue
 ruby
Pull requests that update Ruby code
No Label 🙋 Bounty claim
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
gavin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: gavin/maybe#455
Delete Branch "notification_ui"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?