Fix error when users try to logout #603

2024-04-08T15:02:02+08:00

portovep commented

2024-04-08 15:02:02 +08:00

(Migrated from github.com)

Steps to reproduce
On the dashboard page, after logging it, when the user tries to logouts an internal error is shown.

**Steps to reproduce** On the dashboard page, after logging it, when the user tries to logouts an internal error is shown. <img width="1044" alt="image" src="https://github.com/maybe-finance/maybe/assets/2892293/1a0860df-cd70-43e5-b4e7-8e5b5054f1e8">

portovep (Migrated from github.com) reviewed 2024-04-08 15:10:45 +08:00

test/application_system_test_case.rb

						
				@@ -14,2 +14,3 @@

				    end

				    assert_text "Dashboard"

				    assert_text "Dashboard", wait: 5

				    find('[data-controller="menu"]').click

portovep (Migrated from github.com) commented

2024-04-08 15:10:44 +08:00

While adding a test to cover the broken functionality, I ran into some flakiness running the test. The dashboard page was taking a bit longer to load and the default 2 seconds waiting time was not enough.

I increased the default Capybara waiting time from up to 2 seconds to up to 5 seconds to make the test more stable.

While adding a test to cover the broken functionality, I ran into some flakiness running the test. The dashboard page was taking a bit longer to load and the default 2 seconds waiting time was not enough. I increased the default Capybara waiting time from up to 2 seconds to up to 5 seconds to make the test more stable.

zachgoll (Migrated from github.com) approved these changes 2024-04-08 19:26:31 +08:00

zachgoll (Migrated from github.com) left a comment

Thanks for the fix, looks good 👍

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: gavin/maybe#603