gavin/maybe
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 28 Wiki Activity

implement new-transaction modal #632

Closed
b4s36t4 wants to merge 3 commits from feat/new-transaction into main
pull from: feat/new-transaction
merge into: gavin:main
Conversation 2 Commits 3 Files Changed 7 +63 -12
b4s36t4 commented 2024-04-16 07:08:28 +08:00 (Migrated from github.com)
Copy Link

/claim #629

/closes #629

This PR replaces the current /new route for transaction and adds a modal for the new-transaction flow.

This is purely inspired from the existing account creation flow.

Implementation Details.

  • Update the route with modal
  • Implement the form fields along with the category
  • Handle redirection after save with all the turbo-streams
  • Auto-close the modal after the event is success.

Video

https://github.com/maybe-finance/maybe/assets/59088937/2434d75d-c0c9-496b-b3b5-6518d941e3ba

/claim #629 /closes #629 This PR replaces the current `/new` route for transaction and adds a modal for the new-transaction flow. This is purely inspired from the existing `account` creation flow. ## Implementation Details. * Update the route with modal * Implement the form fields along with the category * Handle redirection after save with all the turbo-streams * Auto-close the modal after the event is success. ## Video https://github.com/maybe-finance/maybe/assets/59088937/2434d75d-c0c9-496b-b3b5-6518d941e3ba
therealtimex commented 2024-04-16 13:02:24 +08:00 (Migrated from github.com)
Copy Link

Is it possible to upload files (receipt, etc)?

Is it possible to upload files (receipt, etc)?
zachgoll (Migrated from github.com) reviewed 2024-04-17 02:44:08 +08:00
zachgoll (Migrated from github.com) left a comment
Copy Link

@b4s36t4 thanks for the submission here! We have decided to go with #633 though.

This solution works well but has some inconsistencies with the design spec that was posted in the issue.

Really like the turbo:submit-end hook that you added in here though, I think that's a great way to trigger modal closing for forms as we continue building out features like this.

@b4s36t4 thanks for the submission here! We have decided to go with #633 though. This solution works well but has some inconsistencies with the [design spec](https://www.figma.com/file/lonJmVk3HYkwZoIO7xYP2w/Maybe-App-(Community)?type=design&node-id=2664-225&mode=design&t=p9lOop61MfLabHUV-0) that was posted in the issue. Really like the `turbo:submit-end` hook that you added in here though, I think that's a great way to trigger modal closing for forms as we continue building out features like this.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
zachgoll
Labels
Clear labels
📆 Planned
Not ready to be worked on yet, but planned for future
 💻 Self Hosted only
Issues pertaining to self-hosted versions of Maybe
 ⚙️ Config
ℹ️ Needs info
Further information is requested
 📱 Mobile
Bugs exclusively happening on mobile devices
 1️⃣ High Priority
High priority issues will be worked on next
 🚨 Urgent
Issues that are urgent for app functionality
 3️⃣ Low priority
Contributions accepted, but Maybe team will not be working on this in the near term
 2️⃣ Medium Priority
Community contributions accepted, Maybe team only works on if there are no high priority items open
 ⚡ Performance
Performance issues to address
 🎨 UI / UX
Issues related to UI / UX interactions and design.
 💎 Bounty
💰 Rewarded
📊 Data issue
Issues where the app functionally works, but the data is missing or inaccurate.
 🙋 Bounty claim
$1.5K
Community
This is a great issue for community members to work on
 dependencies
Pull requests that update a dependency file
 Design
Hosted only
Hosted app only
 Required self hoster data migration
Self hosters must run data migrations to resolve this issue
 ruby
Pull requests that update Ruby code
No Label 🙋 Bounty claim
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
gavin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: gavin/maybe#632
Delete Branch "feat/new-transaction"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?