gavin/maybe
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 28 Wiki Activity

WIP: Activestorage profile picture uploads #685

Closed
claudey wants to merge 17 commits from claudey-activestorage-profile-picture-uploads into main
pull from: claudey-activestorage-profile-picture-uploads
merge into: gavin:main
Conversation 2 Commits 17 Files Changed 13 +412 -146
claudey commented 2024-04-27 15:22:12 +08:00 (Migrated from github.com)
Copy Link

Attempt for #674

  • ActiveStorage had no version for 7.0.2.alpha so I had to update to the latest rails

  • Parser gem would not work with 3.3.0 so .ruby-version was updated to 3.3.1

  • Successfully installed activestorage after those changes

  • Attached an avatar field to User model

  • Currently saving successfully

  • Shows in preview after saving.

WIP:

  • Not completed purging user avatar

/claim #674

https://github.com/maybe-finance/maybe/assets/1866816/5c372cb0-3e56-4dc5-9800-8cb22f88b932

Attempt for #674 - ActiveStorage had no version for 7.0.2.alpha so I had to update to the latest rails - Parser gem would not work with 3.3.0 so .ruby-version was updated to 3.3.1 - Successfully installed activestorage after those changes - Attached an avatar field to User model - Currently saving successfully - Shows in preview after saving. WIP: - Not completed purging user avatar /claim #674 https://github.com/maybe-finance/maybe/assets/1866816/5c372cb0-3e56-4dc5-9800-8cb22f88b932
zachgoll commented 2024-05-01 01:39:38 +08:00 (Migrated from github.com)
Copy Link

@claudey thanks for the work on this! I'm going to close it out now as we've merged a completed solution in #687.

@claudey thanks for the work on this! I'm going to close it out now as we've merged a completed solution in #687.
😆 1
claudey commented 2024-05-01 01:59:03 +08:00 (Migrated from github.com)
Copy Link

Thanks for the reply, Zach. I'll keep trying at future issues.

Thanks for the reply, Zach. I'll keep trying at future issues.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
📆 Planned
Not ready to be worked on yet, but planned for future
 💻 Self Hosted only
Issues pertaining to self-hosted versions of Maybe
 ⚙️ Config
ℹ️ Needs info
Further information is requested
 📱 Mobile
Bugs exclusively happening on mobile devices
 1️⃣ High Priority
High priority issues will be worked on next
 🚨 Urgent
Issues that are urgent for app functionality
 3️⃣ Low priority
Contributions accepted, but Maybe team will not be working on this in the near term
 2️⃣ Medium Priority
Community contributions accepted, Maybe team only works on if there are no high priority items open
 ⚡ Performance
Performance issues to address
 🎨 UI / UX
Issues related to UI / UX interactions and design.
 💎 Bounty
💰 Rewarded
📊 Data issue
Issues where the app functionally works, but the data is missing or inaccurate.
 🙋 Bounty claim
$1.5K
Community
This is a great issue for community members to work on
 dependencies
Pull requests that update a dependency file
 Design
Hosted only
Hosted app only
 Required self hoster data migration
Self hosters must run data migrations to resolve this issue
 ruby
Pull requests that update Ruby code
No Label 🙋 Bounty claim
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
gavin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: gavin/maybe#685
Delete Branch "claudey-activestorage-profile-picture-uploads"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?