gavin/maybe
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 28 Wiki Activity

Build sidebar user menu #8

Closed
claudey wants to merge 0 commits from cayitey-build-sidebar-user-menu into main
pull from: cayitey-build-sidebar-user-menu
merge into: gavin:main
Conversation 3 Commits - Files Changed 1660 +1618 -6664
claudey commented 2024-01-04 03:53:12 +08:00 (Migrated from github.com)
Copy Link
  • Added a toggle-controller to handle the toggle action
  • Using stimulus to create the pop-up
  • Icons are from heroicons

This PR is for #5

https://github.com/maybe-finance/maybe/assets/1866816/aa48764e-2cdb-421c-a6df-0795340910a1

- Added a toggle-controller to handle the toggle action - Using stimulus to create the pop-up - Icons are from heroicons This PR is for #5 https://github.com/maybe-finance/maybe/assets/1866816/aa48764e-2cdb-421c-a6df-0795340910a1
Shpigford (Migrated from github.com) reviewed 2024-01-04 03:53:12 +08:00
Shpigford (Migrated from github.com) requested changes 2024-01-04 09:33:38 +08:00
app/views/layouts/application.html.erb
Shpigford (Migrated from github.com) commented 2024-01-04 09:33:02 +08:00
Copy Link

We should be using the raw SVG code instead of SVG images as it gives us more flexibility on things like icon color.

We should be using the raw SVG code instead of SVG images as it gives us more flexibility on things like icon color.
Shpigford (Migrated from github.com) commented 2024-01-04 09:33:33 +08:00
Copy Link

I'd suggest removing the SVG files and just using the SVG code directly in its place.

Otherwise, looks good!

I'd suggest removing the SVG files and just using the SVG code directly in its place. Otherwise, looks good!
claudey (Migrated from github.com) reviewed 2024-01-04 09:50:09 +08:00
app/views/layouts/application.html.erb
claudey (Migrated from github.com) commented 2024-01-04 09:50:09 +08:00
Copy Link

Updated in a4b9a0507d

Updated in https://github.com/maybe-finance/maybe/pull/8/commits/a4b9a0507d06b013aba66bbc56be98b887f518af

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Shpigford
claudey
Labels
Clear labels
📆 Planned
Not ready to be worked on yet, but planned for future
 💻 Self Hosted only
Issues pertaining to self-hosted versions of Maybe
 ⚙️ Config
ℹ️ Needs info
Further information is requested
 📱 Mobile
Bugs exclusively happening on mobile devices
 1️⃣ High Priority
High priority issues will be worked on next
 🚨 Urgent
Issues that are urgent for app functionality
 3️⃣ Low priority
Contributions accepted, but Maybe team will not be working on this in the near term
 2️⃣ Medium Priority
Community contributions accepted, Maybe team only works on if there are no high priority items open
 ⚡ Performance
Performance issues to address
 🎨 UI / UX
Issues related to UI / UX interactions and design.
 💎 Bounty
💰 Rewarded
📊 Data issue
Issues where the app functionally works, but the data is missing or inaccurate.
 🙋 Bounty claim
$1.5K
Community
This is a great issue for community members to work on
 dependencies
Pull requests that update a dependency file
 Design
Hosted only
Hosted app only
 Required self hoster data migration
Self hosters must run data migrations to resolve this issue
 ruby
Pull requests that update Ruby code
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
gavin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: gavin/maybe#8
Delete Branch "cayitey-build-sidebar-user-menu"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?